Firestorm
  1. Firestorm
  2. FIRE-5905

[PATCH] RLV: UNSIT prevents taking and deleting of objects

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: Phoenix Firestorm 4.0.1, Phoenix Firestorm 4.1.1
    • Fix Version/s: Phoenix Firestorm 4.1.1
    • Component/s: None
    • Labels:
    • Environment:
      Mac, Windows 7
    • SL Avatar Name:
      nagi Michinaga
    • Patch attached:
      Patch attached
    • Reported In:
      Firestorm Beta 4.0.1.27000

      Description

      When using RLV, if you are restricted with UNSIT=n, RLVa incorrectly (in my belief) restricts you from being able to pick up, return or delete any objects you should normally be able to affect. Attached please find a patch to correct this, which modifes the check to just restrict an affected avatar from being able to pick up, return or delete an object that they are sitting on, to prevent getting around intended restrictions.

      1. newRLVunsit.diff
        2 kB
        Nagi Michinaga
      2. RLVunsit.diff
        1 kB
        Nagi Michinaga

        Activity

        Hide
        Ansariel Hiller added a comment -

        Assigning to Kitty for review.

        Show
        Ansariel Hiller added a comment - Assigning to Kitty for review.
        Hide
        Kitty Barnett added a comment -

        Expected behaviour:
        Can take, return or delete your own prims if you're not sitting on them.
        Can not take, return or delete prims your own prims if you are sitting on them.

        I checked both and they're working as expected.

        Please provide a step-by-step description of the actual bug you're seeing.

        Show
        Kitty Barnett added a comment - Expected behaviour: Can take, return or delete your own prims if you're not sitting on them. Can not take, return or delete prims your own prims if you are sitting on them. I checked both and they're working as expected. Please provide a step-by-step description of the actual bug you're seeing.
        Hide
        Nagi Michinaga added a comment - - edited

        It doesn't work as i expect at least, which is why i developed the patch. Here's how to reproduce: go to land that you do not own (at least don't have return rights on) but can rez items, sit on something, restrict yourself with unsit=n, and rez something, then try to pick it up. You will find that instead of being able to pick up the item, your menu will have 'Buy' where 'Take' was, and 'Delete' will be greyed out.

        It seems to me that this is orthogonal to the ability to unseat ones self (excepting of course the item one is sat upon). Thus, my patch.

        If you have further questions, please feel free to contact me inworld.

        Show
        Nagi Michinaga added a comment - - edited It doesn't work as i expect at least, which is why i developed the patch. Here's how to reproduce: go to land that you do not own (at least don't have return rights on) but can rez items, sit on something, restrict yourself with unsit=n, and rez something, then try to pick it up. You will find that instead of being able to pick up the item, your menu will have 'Buy' where 'Take' was, and 'Delete' will be greyed out. It seems to me that this is orthogonal to the ability to unseat ones self (excepting of course the item one is sat upon). Thus, my patch. If you have further questions, please feel free to contact me inworld.
        Hide
        Nagi Michinaga added a comment -

        New version of the RLVunsit patch, based off of Kitty's changes to Catznip (http://hg.catznip.com/rlva/changeset/231cdb206a11) Please disregard my previous patch, Kitty's fix is more correct.

        Show
        Nagi Michinaga added a comment - New version of the RLVunsit patch, based off of Kitty's changes to Catznip ( http://hg.catznip.com/rlva/changeset/231cdb206a11 ) Please disregard my previous patch, Kitty's fix is more correct.
        Hide
        Nagi Michinaga added a comment -

        This is now included into the repository as part of changeset 231cdb206a11e9985050a5a3ff5c0872cfd8835a, so please close this ticket.

        Show
        Nagi Michinaga added a comment - This is now included into the repository as part of changeset 231cdb206a11e9985050a5a3ff5c0872cfd8835a, so please close this ticket.
        Hide
        Ansariel Hiller added a comment -

        Fixed in 28507 (http://hg.phoenixviewer.com/phoenix-firestorm-lgpl/rev/231cdb206a11). Already in release branch.

        Show
        Ansariel Hiller added a comment - Fixed in 28507 ( http://hg.phoenixviewer.com/phoenix-firestorm-lgpl/rev/231cdb206a11 ). Already in release branch.

          People

          • Assignee:
            Kitty Barnett
            Reporter:
            Nagi Michinaga
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: