Uploaded image for project: 'Firestorm'
  1. Firestorm
  2. FIRE-20192

[PATCH] [STORM-2138] FIX: Radius calculation is wrong in viewers dating back at least 5 years

    Details

    • Type: Bug
    • Status: Reopened
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: Phoenix Firestorm 4.7.3, Phoenix Firestorm 4.7.5, Phoenix Firestorm 4.7.7, Phoenix Firestorm 4.7.9, Phoenix Firestorm 4.7.10
    • Fix Version/s: Phoenix Firestorm Next
    • Component/s: Mesh
    • Labels:
      None
    • Environment:
    • SL Avatar Name:
      Beq Janus
    • Patch attached:
      Patch attached
    • Reported In:
      Firestorm 4.7.9.50527 Release

      Description

      The attached path fixes a long standing bug that affects the LOD behaviour of certain Mesh objects.
      Full details can be found on http://beqsother.blogspot.co.uk/2016/10/bug-hunting-fixing-ancient-lod-issue.html
      This has been raised as STORM-2138 on the Lab's Jira.

      The patch was made relative to the current firestorm release tree and independent of my related patch to LOD Info.

      The fix includes a debug setting "useLegacyMeshProfile" that will revert to the old behaviour.

      Full rights to use this code are granted.

      1. FIRE-20192_v2.patch
        2 kB
        Beq Janus
      2. STORM-2138.patch
        5 kB
        Beq Janus

        Issue Links

          Activity

          Hide
          whirly.fizzle Whirly Fizzle added a comment -

          Thanks Beq <3

          Show
          whirly.fizzle Whirly Fizzle added a comment - Thanks Beq <3
          Hide
          ansariel.hiller Ansariel Hiller added a comment -

          Fix pushed in 50969 (http://hg.phoenixviewer.com/phoenix-firestorm-lgpl/rev/d91937b1ee63) in slightly different form and with FS-tagging so we keep track what changed.

          Show
          ansariel.hiller Ansariel Hiller added a comment - Fix pushed in 50969 ( http://hg.phoenixviewer.com/phoenix-firestorm-lgpl/rev/d91937b1ee63 ) in slightly different form and with FS-tagging so we keep track what changed.
          Hide
          ansariel.hiller Ansariel Hiller added a comment - - edited

          Re-opening this issue: I had to back out the change in 50971 (http://hg.phoenixviewer.com/phoenix-firestorm-lgpl/rev/e7c4311b6f1c) because it breaks meshes - the Maitreya Lara mesh body in particular: The neck and hands are missing and the feet are covered with a solid pink surface. They render properly with UseLegacyMeshProfile set to TRUE.

          Show
          ansariel.hiller Ansariel Hiller added a comment - - edited Re-opening this issue: I had to back out the change in 50971 ( http://hg.phoenixviewer.com/phoenix-firestorm-lgpl/rev/e7c4311b6f1c ) because it breaks meshes - the Maitreya Lara mesh body in particular: The neck and hands are missing and the feet are covered with a solid pink surface. They render properly with UseLegacyMeshProfile set to TRUE.
          Hide
          whirly.fizzle Whirly Fizzle added a comment - - edited

          Testing on Firestorm 4.7.10 (50970) Oct 7 2016 06:19:09 (Firestorm-Fizzlefirex64) with OpenSimulator support (before the backout).

          I couldn't reproduce this, until I cleared cache.
          After cache purge it reproduces every session.

          I'm seeing slightly different results to Ansa though.
          I'm wearing the Maitreya mesh body and Fiore mesh head here.
          The neck is invisible and the feet render pink as Ansa said above.
          My Maitreya hands are not invisible, however they have the wrong texture on them.

          Pink feet

          Missing neck mesh

          Incorrect texture on Maitreya hands

          Firestorm 4.7.10 (50970) Oct  7 2016 06:19:09 (Firestorm-Fizzlefirex64) with OpenSimulator support
          Release Notes
          
          You are at 15.5, 219.2, 3,182.6 in Firestorm Social Island located at sim10287.agni.lindenlab.com (216.82.49.209:13014)
          SLURL: http://maps.secondlife.com/secondlife/Firestorm%20Social%20Island/16/219/3183
          (global coordinates 167,440.0, 285,147.0, 3,182.6)
          Second Life Server 16.09.23.320027
          Release Notes
          
          CPU: Intel(R) Core(TM) i7-4770K CPU @ 3.50GHz (3491.95 MHz)
          Memory: 16268 MB
          OS Version: Microsoft Windows 7 SP1 64-bit (Build 7601)
          Graphics Card Vendor: NVIDIA Corporation
          Graphics Card: GeForce GTX 750/PCIe/SSE2
          
          Windows Graphics Driver Version: 21.21.0013.7254
          OpenGL Version: 4.5.0 NVIDIA 372.54
          
          RestrainedLove API: RLV v3.1.4 / RLVa v2.0.3.50970
          libcurl Version: libcurl/7.47.0 OpenSSL/1.0.1i zlib/1.2.8
          J2C Decoder Version: KDU v7.8
          Audio Driver Version: FMOD Ex 4.44.61
          LLCEFLib/CEF Version: 1.5.3-(CEF-WIN-3.2526.1347-32)
          Voice Server Version: Vivox 4.6.0017.22050
          
          Settings mode: Hybrid
          Viewer Skin: Firestorm (CtrlAltStudio)
          Font Used: Deja Vu (96 dpi)
          Font Size Adjustment: 0 pt
          UI Scaling: 1
          Draw distance: 744 m
          Bandwidth: 1500 kbit/s
          LOD factor: 4
          Render quality: High-Ultra (6/7)
          Advanced Lighting Model: Yes
          Texture memory: 768 MB (1)
          VFS (cache) creation time (UTC): 2016-10-7T5:58:6 
          Built with MSVC version 1800
          Packets Lost: 0/54,132 (0.0%)
          October 06 2016 23:12:09
          
          Show
          whirly.fizzle Whirly Fizzle added a comment - - edited Testing on Firestorm 4.7.10 (50970) Oct 7 2016 06:19:09 (Firestorm-Fizzlefirex64) with OpenSimulator support (before the backout). I couldn't reproduce this, until I cleared cache. After cache purge it reproduces every session. I'm seeing slightly different results to Ansa though. I'm wearing the Maitreya mesh body and Fiore mesh head here. The neck is invisible and the feet render pink as Ansa said above. My Maitreya hands are not invisible, however they have the wrong texture on them. Pink feet Missing neck mesh Incorrect texture on Maitreya hands Firestorm 4.7.10 (50970) Oct 7 2016 06:19:09 (Firestorm-Fizzlefirex64) with OpenSimulator support Release Notes You are at 15.5, 219.2, 3,182.6 in Firestorm Social Island located at sim10287.agni.lindenlab.com (216.82.49.209:13014) SLURL: http: //maps.secondlife.com/secondlife/Firestorm%20Social%20Island/16/219/3183 (global coordinates 167,440.0, 285,147.0, 3,182.6) Second Life Server 16.09.23.320027 Release Notes CPU: Intel(R) Core(TM) i7-4770K CPU @ 3.50GHz (3491.95 MHz) Memory: 16268 MB OS Version: Microsoft Windows 7 SP1 64-bit (Build 7601) Graphics Card Vendor: NVIDIA Corporation Graphics Card: GeForce GTX 750/PCIe/SSE2 Windows Graphics Driver Version: 21.21.0013.7254 OpenGL Version: 4.5.0 NVIDIA 372.54 RestrainedLove API: RLV v3.1.4 / RLVa v2.0.3.50970 libcurl Version: libcurl/7.47.0 OpenSSL/1.0.1i zlib/1.2.8 J2C Decoder Version: KDU v7.8 Audio Driver Version: FMOD Ex 4.44.61 LLCEFLib/CEF Version: 1.5.3-(CEF-WIN-3.2526.1347-32) Voice Server Version: Vivox 4.6.0017.22050 Settings mode: Hybrid Viewer Skin: Firestorm (CtrlAltStudio) Font Used: Deja Vu (96 dpi) Font Size Adjustment: 0 pt UI Scaling: 1 Draw distance: 744 m Bandwidth: 1500 kbit/s LOD factor: 4 Render quality: High-Ultra (6/7) Advanced Lighting Model: Yes Texture memory: 768 MB (1) VFS (cache) creation time (UTC): 2016-10-7T5:58:6 Built with MSVC version 1800 Packets Lost: 0/54,132 (0.0%) October 06 2016 23:12:09
          Hide
          whirly.fizzle Whirly Fizzle added a comment -

          The LAQ Trinity mesh head isn't rendering correctly either.

          Show
          whirly.fizzle Whirly Fizzle added a comment - The LAQ Trinity mesh head isn't rendering correctly either.
          Hide
          whirly.fizzle Whirly Fizzle added a comment - - edited

          Catwa Nicky mesh head has the system skin texture rendering on the mesh eyelashes: http://prnt.sc/cqty9z
          When you teleport the textures on the affected mesh change, I think it's just picking up random textures from the nearby scene.

          Mesh rezzed inworld is also affected - http://prnt.sc/cqu0rl

          Show
          whirly.fizzle Whirly Fizzle added a comment - - edited Catwa Nicky mesh head has the system skin texture rendering on the mesh eyelashes: http://prnt.sc/cqty9z When you teleport the textures on the affected mesh change, I think it's just picking up random textures from the nearby scene. Mesh rezzed inworld is also affected - http://prnt.sc/cqu0rl
          Hide
          beqphoenixjira Beq Janus added a comment -

          Very very strange. Thank you for the tests. I'll be back home in a couple of hours. My flight just landed. This behaviour is reminiscent of bugs related to cache corruption I wonder what it is? I'll pick it up this evening and let you know what I find.

          Show
          beqphoenixjira Beq Janus added a comment - Very very strange. Thank you for the tests. I'll be back home in a couple of hours. My flight just landed. This behaviour is reminiscent of bugs related to cache corruption I wonder what it is? I'll pick it up this evening and let you know what I find.
          Hide
          beqphoenixjira Beq Janus added a comment -

          This is what is feared that there's hidden reasons why those parameters are that way, though I'm curious as to why I never saw it, perhaps the cache thing you noted in your first treats whirly

          Show
          beqphoenixjira Beq Janus added a comment - This is what is feared that there's hidden reasons why those parameters are that way, though I'm curious as to why I never saw it, perhaps the cache thing you noted in your first treats whirly
          Hide
          beqphoenixjira Beq Janus added a comment - - edited

          A revised fix for the above problem is now attached. It is actually a simpler fix and in many ways better (aside from avoiding the side effects). I rejected this before in favour of addressing the fault at source. Bad choice!

          As far as I can tell this does not exhibit any of the preceding bugs.

          Please note, that because this change now lives in the llvolume module of the llmath library it does not have simple access to the llcontrol functions and thus I have removed the "uselegacy" switch as well.

          Show
          beqphoenixjira Beq Janus added a comment - - edited A revised fix for the above problem is now attached. It is actually a simpler fix and in many ways better (aside from avoiding the side effects). I rejected this before in favour of addressing the fault at source. Bad choice! As far as I can tell this does not exhibit any of the preceding bugs. Please note, that because this change now lives in the llvolume module of the llmath library it does not have simple access to the llcontrol functions and thus I have removed the "uselegacy" switch as well.
          Hide
          whirly.fizzle Whirly Fizzle added a comment -

          I only had time to test this quickly but so far I'm not seeing any wonky textures with the new patch.
          I'll run with this patch for a couple of days & see how things go

          Show
          whirly.fizzle Whirly Fizzle added a comment - I only had time to test this quickly but so far I'm not seeing any wonky textures with the new patch. I'll run with this patch for a couple of days & see how things go
          Hide
          ansariel.hiller Ansariel Hiller added a comment -

          How did the test go?

          Show
          ansariel.hiller Ansariel Hiller added a comment - How did the test go?

            People

            • Assignee:
              Unassigned
              Reporter:
              beqphoenixjira Beq Janus
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: