Uploaded image for project: 'Firestorm'
  1. Firestorm
  2. FIRE-6563

Windlight water settings (Quick Prefs) are overriden permanently by estate settings

    Details

    • Type: Bug
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: Phoenix Firestorm 4.0.1
    • Component/s: None
    • Labels:
    • Environment:
    • SL Avatar Name:
      Cheshyr Pontchartrain
    • Reported In:
      Firestorm Beta 4.0.1.27000

      Description

      After visiting any sim that sets the Windlight water settings, Firestorm's "quick prefs" are permanently set to match. For example, two days ago I visited a sim with green water. Every sim I went to thereafter showed green water, including my home sim which had per-parcel water defined. I had to edit quick prefs and switch back to default to fix this.

      Expected behavior: Parcel or estate settings are temporary, and should never change preferences beyond the scope of the visit.

      1. Whirly_1.log
        397 kB
        Whirly Fizzle
      1. windlight settings.png
        134 kB

        Issue Links

          Activity

          Hide
          cheshyr Cheshyr Pontchartrain added a comment -

          See PHOE-3038 for the original Phoenix report. The developers have been aware of this bug for well over a year. Whirly et al, how do we mark items as duplicates or related? This version of the JIRA seems to be missing several options.

          Show
          cheshyr Cheshyr Pontchartrain added a comment - See PHOE-3038 for the original Phoenix report. The developers have been aware of this bug for well over a year. Whirly et al, how do we mark items as duplicates or related? This version of the JIRA seems to be missing several options.
          Hide
          whirly.fizzle Whirly Fizzle added a comment -

          Hiya Cheshyr,

          Do you happen to remember the SLURL of that region with green water, or know if they had the water set with estate windlight or parcel windlight?

          Ill have a look at all the cases listed in PHOE-3038 also

          You have only noticed this with the water windlight, not the sky?

          Show
          whirly.fizzle Whirly Fizzle added a comment - Hiya Cheshyr, Do you happen to remember the SLURL of that region with green water, or know if they had the water set with estate windlight or parcel windlight? Ill have a look at all the cases listed in PHOE-3038 also You have only noticed this with the water windlight, not the sky?
          Hide
          cheshyr Cheshyr Pontchartrain added a comment -

          I'm afraid don't know the region. I was helping a customer. When I got back to Gallifrey, my water had turned green. Prior to that, it was also the wrong texture, but neutral enough I hadn't cared.

          Windlight sky changes proper. Water doesn't. I "fixed" it on Gallifrey, by forcing water to default in all my parcel descriptions. The estate setting had no impact.

          Show
          cheshyr Cheshyr Pontchartrain added a comment - I'm afraid don't know the region. I was helping a customer. When I got back to Gallifrey, my water had turned green. Prior to that, it was also the wrong texture, but neutral enough I hadn't cared. Windlight sky changes proper. Water doesn't. I "fixed" it on Gallifrey, by forcing water to default in all my parcel descriptions. The estate setting had no impact.
          Hide
          whirly.fizzle Whirly Fizzle added a comment -

          Cheshyr Pontchartrain
          Are you still seeing this problem on 4.7.9?
          I'm unable to reproduce it.

          Show
          whirly.fizzle Whirly Fizzle added a comment - Cheshyr Pontchartrain Are you still seeing this problem on 4.7.9? I'm unable to reproduce it.
          Hide
          cheshyr Cheshyr Pontchartrain added a comment -

          I filed this bug 4 years ago, LOL. I couldn't say, though I do notice the opposite behavior. My estate's water setting is ignored. Every time I login, or teleport back to Gallifrey, I see the default water instead of the settings I selected in estate tools.

          Show
          cheshyr Cheshyr Pontchartrain added a comment - I filed this bug 4 years ago, LOL. I couldn't say, though I do notice the opposite behavior. My estate's water setting is ignored. Every time I login, or teleport back to Gallifrey, I see the default water instead of the settings I selected in estate tools.
          Hide
          nathan adored Nathan Adored added a comment - - edited

          I dunno if this is related, but I've had instances where I go to someplace that has Windlight settings on it – say, New Gallifrey, with its red, red skies – and then TP somewhere that doesn't have any Windlight settings, such as my home parcel on Whippersnapper, I find I still have the Wndlight settings operating that were on the place I just arrived from. If I then click on the About part of the toolbar (the line that shows the sim name and my av's coordinates and stuff) such that the About Land pane comes up, the Windlight effects instantly go away and everything is back to normal.

          Show
          nathan adored Nathan Adored added a comment - - edited I dunno if this is related, but I've had instances where I go to someplace that has Windlight settings on it – say, New Gallifrey, with its red, red skies – and then TP somewhere that doesn't have any Windlight settings, such as my home parcel on Whippersnapper, I find I still have the Wndlight settings operating that were on the place I just arrived from. If I then click on the About part of the toolbar (the line that shows the sim name and my av's coordinates and stuff) such that the About Land pane comes up, the Windlight effects instantly go away and everything is back to normal.
          Hide
          whirly.fizzle Whirly Fizzle added a comment -

          Cheshyr Pontchartrain
          There's been a round of windlight fixes, that's why I came back to this issue now

          • On Gallifrey, region windlight is set to a custom fixed sky and custom water setting "Gallifrey".
          • Can you tell me which water windlight you set for the region water setting please. The estate environment is rather unhelpful in that it renames the fixed sky/water to the region name.
            I want to know what water setting you are using to make sure I'm seeing the water correctly when viewing the region windlight.
          • You have 9 parcels on Gallifrey each with a different parcel windlight set.

          My estate's water setting is ignored. Every time I login, or teleport back to Gallifrey, I see the default water instead of the settings I selected in estate tools.

          Ok so behaviour here depends on your viewer settings & whether you have the viewer set to always use the region windlight or parcel windlight.
          Can you go to Preferences -> Firestorm -> Windlight & take a screenshot of that panel & attach it to this issue using More Actions -> Attach files.

          Do you see the same problem when you teleport into Gallifrey when you TP into all your parcels or just some of them?

          Show
          whirly.fizzle Whirly Fizzle added a comment - Cheshyr Pontchartrain There's been a round of windlight fixes, that's why I came back to this issue now On Gallifrey, region windlight is set to a custom fixed sky and custom water setting "Gallifrey". Can you tell me which water windlight you set for the region water setting please. The estate environment is rather unhelpful in that it renames the fixed sky/water to the region name. I want to know what water setting you are using to make sure I'm seeing the water correctly when viewing the region windlight. You have 9 parcels on Gallifrey each with a different parcel windlight set. My estate's water setting is ignored. Every time I login, or teleport back to Gallifrey, I see the default water instead of the settings I selected in estate tools. Ok so behaviour here depends on your viewer settings & whether you have the viewer set to always use the region windlight or parcel windlight. Can you go to Preferences -> Firestorm -> Windlight & take a screenshot of that panel & attach it to this issue using More Actions -> Attach files. Do you see the same problem when you teleport into Gallifrey when you TP into all your parcels or just some of them?
          Hide
          whirly.fizzle Whirly Fizzle added a comment -

          Nathan Adored
          Reproduced.
          Investigating.

          Show
          whirly.fizzle Whirly Fizzle added a comment - Nathan Adored Reproduced. Investigating.
          Hide
          whirly.fizzle Whirly Fizzle added a comment - - edited

          Nathan's bug

          Ok, New Gallifrey has an invalid parcel windlight set, which can cause the windlight to get stuck after leaving the area.

          After TPing into New Gallifrey, logs show

          newview/kcwlinterface.cpp(256) : 2016-10-02T06:36:03Z INFO: KCWindlightInterface::applySkySettings: Applying WL sky set "Region Default": No zone and no default sky defined
          newview/kcwlinterface.cpp(202) : 2016-10-02T06:36:03Z WARNING: KCWindlightInterface::applySettings: Cannot apply Parcel WL water preset because region WL default has been set due to invalid sky preset
          

          The Gallifrey windlight failed to apply here.

          It's erratic though, sometimes the New Gallifrey region windlight will load when TPing to location A and sometimes it will not.
          When a parcel has an invalid windlight set, this can cause the windlight to get stuck when TPing to other regions.

          Now I'm trying to work out why the parcel windlight on New Gallifrey is invalid...

          Show
          whirly.fizzle Whirly Fizzle added a comment - - edited Nathan's bug Location A - Gallifrey : http://maps.secondlife.com/secondlife/New%20Gallifrey/180/147/47 Region WL = Custom day cycle (red sky & red clouds). Parcel WL = /*Windlight Sky @ 3950m to 4096m: "Phototools- No Light" RegionOverride*/ Location B - Nathans : http://maps.secondlife.com/secondlife/Whippersnapper/23/13/22 Region WL = Default day cycle. Parcel WL = None. Ok, New Gallifrey has an invalid parcel windlight set, which can cause the windlight to get stuck after leaving the area. After TPing into New Gallifrey, logs show newview/kcwlinterface.cpp(256) : 2016-10-02T06:36:03Z INFO: KCWindlightInterface::applySkySettings: Applying WL sky set "Region Default" : No zone and no default sky defined newview/kcwlinterface.cpp(202) : 2016-10-02T06:36:03Z WARNING: KCWindlightInterface::applySettings: Cannot apply Parcel WL water preset because region WL default has been set due to invalid sky preset The Gallifrey windlight failed to apply here. It's erratic though, sometimes the New Gallifrey region windlight will load when TPing to location A and sometimes it will not. When a parcel has an invalid windlight set, this can cause the windlight to get stuck when TPing to other regions. Now I'm trying to work out why the parcel windlight on New Gallifrey is invalid...
          Hide
          ansariel.hiller Ansariel Hiller added a comment -

          Try again with the debug output enabled. It will print out what is actually matched from the string in the parcel description.

          Show
          ansariel.hiller Ansariel Hiller added a comment - Try again with the debug output enabled. It will print out what is actually matched from the string in the parcel description.
          Hide
          anguschill anguschill Resident added a comment - - edited
          /*Sky@1400m-1700m:"Phototools- Epi Vintage Light" Sky@1750m-2400m: "Midday" Sky@2700m-3050m: "Ambient Dark" Sky@3000m-3700m: "Dusty" RegionOverride*/
          newview/kcwlinterface.cpp(435) : 2016-10-02T09:59:40Z DEBUG: KCWindlightInterface::parseParcelForWLSettings: Sky Flags: type = Sky from = 1400 to = 1700 preset = Phototools- Epi Vintage Light
          newview/kcwlinterface.cpp(435) : 2016-10-02T09:59:40Z DEBUG: KCWindlightInterface::parseParcelForWLSettings: Sky Flags: type = Sky from = 1750 to = 2400 preset = Midday
          newview/kcwlinterface.cpp(435) : 2016-10-02T09:59:40Z DEBUG: KCWindlightInterface::parseParcelForWLSettings: Sky Flags: type = Sky from = 2700 to = 3050 preset = Ambient Dark
          newview/kcwlinterface.cpp(435) : 2016-10-02T09:59:40Z DEBUG: KCWindlightInterface::parseParcelForWLSettings: Sky Flags: type = Sky from = 3000 to = 3700 preset = Dusty
          newview/kcwlinterface.cpp(256) : 2016-10-02T09:59:40Z INFO: KCWindlightInterface::applySkySettings: Applying WL sky set "Region Default": No zone and no default sky defined
          newview/kcwlinterface.cpp(202) : 2016-10-02T09:59:40Z WARNING: KCWindlightInterface::applySettings: Cannot apply Parcel WL water preset because region WL default has been set due to invalid sky preset

          I tped to an altitude of 30.

          When I tp to a parcel with WL settings in general (like a single WL sky zone (both with or without a RegionOverride flag)) but which has NO default (ground) sky WL for the whole parcel to an ALTITUDE where NO ZONE has been defined I get those error messages. For me personally the last region's WL is applied in 4.7.10.50953 (with crossfade options disabled!) instead of the actual region WL without fail. Parcel WL is applied correctly if I tp to an altitude where a zone has been defined and I see no error messages in the logs.

          http://maps.secondlife.com/secondlife/Eduisland%202/178/65/19 or
          http://maps.secondlife.com/secondlife/Slime%20Square/132/121/39 (no WL zone defined at this altitude)

          http://maps.secondlife.com/secondlife/Eduisland%202/178/65/2310 or
          http://maps.secondlife.com/secondlife/Slime%20Square/144/140/13 (WL zone defined at this altitude)

          Sorry! I get email notifications on that other JIRA and it was so tempting...

          Show
          anguschill anguschill Resident added a comment - - edited /*Sky@1400m-1700m: "Phototools- Epi Vintage Light" Sky@1750m-2400m: "Midday" Sky@2700m-3050m: "Ambient Dark" Sky@3000m-3700m: "Dusty" RegionOverride*/ newview/kcwlinterface.cpp(435) : 2016-10-02T09:59:40Z DEBUG: KCWindlightInterface::parseParcelForWLSettings: Sky Flags: type = Sky from = 1400 to = 1700 preset = Phototools- Epi Vintage Light newview/kcwlinterface.cpp(435) : 2016-10-02T09:59:40Z DEBUG: KCWindlightInterface::parseParcelForWLSettings: Sky Flags: type = Sky from = 1750 to = 2400 preset = Midday newview/kcwlinterface.cpp(435) : 2016-10-02T09:59:40Z DEBUG: KCWindlightInterface::parseParcelForWLSettings: Sky Flags: type = Sky from = 2700 to = 3050 preset = Ambient Dark newview/kcwlinterface.cpp(435) : 2016-10-02T09:59:40Z DEBUG: KCWindlightInterface::parseParcelForWLSettings: Sky Flags: type = Sky from = 3000 to = 3700 preset = Dusty newview/kcwlinterface.cpp(256) : 2016-10-02T09:59:40Z INFO: KCWindlightInterface::applySkySettings: Applying WL sky set "Region Default" : No zone and no default sky defined newview/kcwlinterface.cpp(202) : 2016-10-02T09:59:40Z WARNING: KCWindlightInterface::applySettings: Cannot apply Parcel WL water preset because region WL default has been set due to invalid sky preset I tped to an altitude of 30. When I tp to a parcel with WL settings in general (like a single WL sky zone (both with or without a RegionOverride flag)) but which has NO default (ground) sky WL for the whole parcel to an ALTITUDE where NO ZONE has been defined I get those error messages. For me personally the last region's WL is applied in 4.7.10.50953 (with crossfade options disabled!) instead of the actual region WL without fail. Parcel WL is applied correctly if I tp to an altitude where a zone has been defined and I see no error messages in the logs. http://maps.secondlife.com/secondlife/Eduisland%202/178/65/19 or http://maps.secondlife.com/secondlife/Slime%20Square/132/121/39 (no WL zone defined at this altitude) http://maps.secondlife.com/secondlife/Eduisland%202/178/65/2310 or http://maps.secondlife.com/secondlife/Slime%20Square/144/140/13 (WL zone defined at this altitude) Sorry! I get email notifications on that other JIRA and it was so tempting...
          Hide
          ansariel.hiller Ansariel Hiller added a comment - - edited

          Added even more debugging messages in 50959 (http://hg.phoenixviewer.com/phoenix-firestorm-lgpl/rev/b10b9c7ed317) to see what's going on.

          Whirly Fizzle the SLurl you provided shows height 47m, but there is only a WL defined for 3950 to 4096m. Based on that it's not a bug that you don't see parcel WL at 47m.

          Show
          ansariel.hiller Ansariel Hiller added a comment - - edited Added even more debugging messages in 50959 ( http://hg.phoenixviewer.com/phoenix-firestorm-lgpl/rev/b10b9c7ed317 ) to see what's going on. Whirly Fizzle the SLurl you provided shows height 47m, but there is only a WL defined for 3950 to 4096m. Based on that it's not a bug that you don't see parcel WL at 47m.
          Hide
          cheshyr Cheshyr Pontchartrain added a comment - - edited

          Attached a screenshot of my Windlight settings, per Whirly's request.

          Show
          cheshyr Cheshyr Pontchartrain added a comment - - edited Attached a screenshot of my Windlight settings, per Whirly's request.
          Hide
          cheshyr Cheshyr Pontchartrain added a comment - - edited

          @Whirly Fizzle

          Gallifrey's estate Windlight settings are Coastal Afternoon for the sky, Glassy water. Each parcel has an override in the description to turn it dark above 585m and change the local sky to match the garden biome, After teleporting home (Gallifrey 128/128/20), the water reverts to default, but the sky settings are applied. This occurs even if I teleport home from within the sim.

          My assumption is that Firestorm's parcel Windlight settings are overriding estate water, even if it's not set.

          Show
          cheshyr Cheshyr Pontchartrain added a comment - - edited @Whirly Fizzle Gallifrey's estate Windlight settings are Coastal Afternoon for the sky, Glassy water. Each parcel has an override in the description to turn it dark above 585m and change the local sky to match the garden biome, After teleporting home (Gallifrey 128/128/20), the water reverts to default, but the sky settings are applied. This occurs even if I teleport home from within the sim. My assumption is that Firestorm's parcel Windlight settings are overriding estate water, even if it's not set.
          Hide
          ansariel.hiller Ansariel Hiller added a comment -

          If a WL is applied and the region defaults are disabled, this will affect water in a way it should select the last manually selected water AFAIR.

          Show
          ansariel.hiller Ansariel Hiller added a comment - If a WL is applied and the region defaults are disabled, this will affect water in a way it should select the last manually selected water AFAIR.
          Hide
          whirly.fizzle Whirly Fizzle added a comment -

          Ansariel Hiller

          Whirly Fizzle the SLurl you provided shows height 47m, but there is only a WL defined for 3950 to 4096m. Based on that it's not a bug that you don't see parcel WL at 47m.

          The bug here was that the region windlight sky was often not being applied at 47m, unless I opened either the estate floater or World -> About land/parcel details floater.
          Instead I would still be viewing the previous regions windlight.
          Also after TPing out of New Gallifrey to Nathans region, often the default Day Cycle region windlight set on Nathns region wouldn't apply (Nathan has no PW set). I would still be seeing the New Gallifrey region windlight until I opened either About land or Resgion/Estate floater.

          Anyway I'll build with that latest commit & see what happens and write up a detailed repro if I'm still seeing funky behaviour.

          Show
          whirly.fizzle Whirly Fizzle added a comment - Ansariel Hiller Whirly Fizzle the SLurl you provided shows height 47m, but there is only a WL defined for 3950 to 4096m. Based on that it's not a bug that you don't see parcel WL at 47m. The bug here was that the region windlight sky was often not being applied at 47m, unless I opened either the estate floater or World -> About land/parcel details floater. Instead I would still be viewing the previous regions windlight. Also after TPing out of New Gallifrey to Nathans region, often the default Day Cycle region windlight set on Nathns region wouldn't apply (Nathan has no PW set). I would still be seeing the New Gallifrey region windlight until I opened either About land or Resgion/Estate floater. Anyway I'll build with that latest commit & see what happens and write up a detailed repro if I'm still seeing funky behaviour.
          Hide
          whirly.fizzle Whirly Fizzle added a comment - - edited

          Dealing with Nathan's bug first.
          Still repros on Firestorm 4.7.10 (50975) Oct 7 2016 08:01:18 (Firestorm-Fizzlefirex64) with OpenSimulator support

          Observed

          • Roughly 50% of the time, the windlight will not be applied correctly when entering each location.
          • Often when TPing from A to B, you will still see the region windlight from A at location B until you open the About land or Region/Estate floater.
          • The same applies when TPing from B to A. You will still see location B windlight when entering location A until you open the About land or Region/Estate floater.

          Location A - http://maps.secondlife.com/secondlife/New%20Gallifrey/180/147/47 .

          • Region WL - Custom Day Cycle (red sky).
          • Parcel Windlight
            /*Windlight Sky @ 3950m to 4096m: "Phototools- No Light" RegionOverride*/
            

            Note that at location A at 47m you should therefore always see the region windlight.

          Location B - http://maps.secondlife.com/secondlife/Whippersnapper/23/13/22 (Nathan's place)

          • Region WL - Default Day Cycle.
          • Parcel WL - None.
          Show
          whirly.fizzle Whirly Fizzle added a comment - - edited Dealing with Nathan's bug first. Still repros on Firestorm 4.7.10 (50975) Oct 7 2016 08:01:18 (Firestorm-Fizzlefirex64) with OpenSimulator support Set Windlight settings like so: http://prnt.sc/crj3dy Crossfade is disabled to make sure results are not affected by the crossfade bug anguschill Resident reported. Teleport between these 2 locations a few times A - http://maps.secondlife.com/secondlife/New%20Gallifrey/180/147/47 B - http://maps.secondlife.com/secondlife/Whippersnapper/23/13/22 (Nathan's place). Observed Roughly 50% of the time, the windlight will not be applied correctly when entering each location. Often when TPing from A to B, you will still see the region windlight from A at location B until you open the About land or Region/Estate floater. The same applies when TPing from B to A. You will still see location B windlight when entering location A until you open the About land or Region/Estate floater. Location A - http://maps.secondlife.com/secondlife/New%20Gallifrey/180/147/47 . Region WL - Custom Day Cycle (red sky). Parcel Windlight /*Windlight Sky @ 3950m to 4096m: "Phototools- No Light" RegionOverride*/ Note that at location A at 47m you should therefore always see the region windlight. Location B - http://maps.secondlife.com/secondlife/Whippersnapper/23/13/22 (Nathan's place) Region WL - Default Day Cycle. Parcel WL - None.
          Hide
          whirly.fizzle Whirly Fizzle added a comment - - edited

          Ansariel Hiller

          • newview/llwlhandlers.cpp(121) : 2016-10-09T01:22:50Z INFO:#WindlightCaps LLEnvironmentRequest::environmentRequestCoro: Received region windlight settings
            newview/kcwlinterface.cpp(640) : 2016-10-09T01:22:50Z INFO: KCWindlightInterface::haveParcelOverride: Region environment settings received. Parcel WL settings will be overridden. Reason: No "RegionOverride", region not using default WL and no zones defined or Parcel WL settings received - Region settings taking precedence
            
          • I presume this is where I clicked "Allow" on the parcel WL prompt?
            newview/kcwlinterface.cpp(439) : 2016-10-09T01:23:01Z DEBUG: KCWindlightInterface::parseParcelForWLSettings: Sky Flags: type = Sky from = 3950 to = 4096 preset = Phototools- No Light
            newview/kcwlinterface.cpp(487) : 2016-10-09T01:23:01Z DEBUG: KCWindlightInterface::parseParcelForWLSettings: Got Region Override Flag
            
          • Then
            newview/kcwlinterface.cpp(211) : 2016-10-09T01:23:02Z DEBUG: KCWindlightInterface::applySkySettings: Checking if agent is in a defined zone
            newview/kcwlinterface.cpp(236) : 2016-10-09T01:23:02Z DEBUG: KCWindlightInterface::applySkySettings: Agent is not within a defined zone. Trying default now
            newview/kcwlinterface.cpp(260) : 2016-10-09T01:23:02Z INFO: KCWindlightInterface::applySkySettings: Applying WL sky set "Region Default": No zone or not in a defined zone and no default sky defined
            newview/kcwlinterface.cpp(202) : 2016-10-09T01:23:02Z WARNING: KCWindlightInterface::applySettings: Cannot apply Parcel WL water preset because region WL default has been set due to invalid sky preset
            newview/kcwlinterface.cpp(211) : 2016-10-09T01:23:07Z DEBUG: KCWindlightInterface::applySkySettings: Checking if agent is in a defined zone
            newview/kcwlinterface.cpp(236) : 2016-10-09T01:23:07Z DEBUG: KCWindlightInterface::applySkySettings: Agent is not within a defined zone. Trying default now
            
          • No further WL logging after this. I am seeing the correct region WL.
          • newview/llagent.cpp(995) : 2016-10-09T01:30:43Z INFO:#AgentLocation LLAgent::setRegion: Moving agent into region: Whippersnapper located at 216.82.50.48:13019
            newview/llwlhandlers.cpp(53) : 2016-10-09T01:30:43Z INFO:#WindlightCaps LLEnvironmentRequest::initiate: Deferring windlight settings request until we've got region caps
            
            newview/kcwlinterface.cpp(211) : 2016-10-09T01:30:45Z DEBUG: KCWindlightInterface::applySkySettings: Checking if agent is in a defined zone
            newview/kcwlinterface.cpp(236) : 2016-10-09T01:30:45Z DEBUG: KCWindlightInterface::applySkySettings: Agent is not within a defined zone. Trying default now
            
            newview/kcwlinterface.cpp(111) : 2016-10-09T01:30:46Z DEBUG: KCWindlightInterface::parcelChange: Agent in new parcel: 554
            newview/llagent.cpp(4598) : 2016-10-09T01:30:46Z INFO:#Teleport LLAgent::handleTeleportFinished: Agent handling teleport finished.
            
          • I Open Region/Estate floater and the WL correctly changes to the default day cycle:
            newview/llwlhandlers.cpp(121) : 2016-10-09T01:37:52Z INFO:#WindlightCaps LLEnvironmentRequest::environmentRequestCoro: Received region windlight settings
            newview/kcwlinterface.cpp(640) : 2016-10-09T01:37:52Z INFO: KCWindlightInterface::haveParcelOverride: Region environment settings received. Parcel WL settings will be overridden. Reason: No "RegionOverride", region not using default WL and no zones defined or Parcel WL settings received - Region settings taking precedence
            
            newview/kcwlinterface.cpp(640) : 2016-10-09T01:37:52Z INFO: KCWindlightInterface::haveParcelOverride: Region environment settings received. Parcel WL settings will be overridden. Reason: No "RegionOverride", region not using default WL and no zones defined or Parcel WL settings received - Region settings taking precedence
            
          • Whirly_1.log attached from that session.
          Show
          whirly.fizzle Whirly Fizzle added a comment - - edited Ansariel Hiller Logging into Location A - http://maps.secondlife.com/secondlife/New%20Gallifrey/180/147/47 I correctly saw the region windlight (red sky). newview/llwlhandlers.cpp(121) : 2016-10-09T01:22:50Z INFO:#WindlightCaps LLEnvironmentRequest::environmentRequestCoro: Received region windlight settings newview/kcwlinterface.cpp(640) : 2016-10-09T01:22:50Z INFO: KCWindlightInterface::haveParcelOverride: Region environment settings received. Parcel WL settings will be overridden. Reason: No "RegionOverride" , region not using default WL and no zones defined or Parcel WL settings received - Region settings taking precedence I presume this is where I clicked "Allow" on the parcel WL prompt? newview/kcwlinterface.cpp(439) : 2016-10-09T01:23:01Z DEBUG: KCWindlightInterface::parseParcelForWLSettings: Sky Flags: type = Sky from = 3950 to = 4096 preset = Phototools- No Light newview/kcwlinterface.cpp(487) : 2016-10-09T01:23:01Z DEBUG: KCWindlightInterface::parseParcelForWLSettings: Got Region Override Flag Then newview/kcwlinterface.cpp(211) : 2016-10-09T01:23:02Z DEBUG: KCWindlightInterface::applySkySettings: Checking if agent is in a defined zone newview/kcwlinterface.cpp(236) : 2016-10-09T01:23:02Z DEBUG: KCWindlightInterface::applySkySettings: Agent is not within a defined zone. Trying default now newview/kcwlinterface.cpp(260) : 2016-10-09T01:23:02Z INFO: KCWindlightInterface::applySkySettings: Applying WL sky set "Region Default" : No zone or not in a defined zone and no default sky defined newview/kcwlinterface.cpp(202) : 2016-10-09T01:23:02Z WARNING: KCWindlightInterface::applySettings: Cannot apply Parcel WL water preset because region WL default has been set due to invalid sky preset newview/kcwlinterface.cpp(211) : 2016-10-09T01:23:07Z DEBUG: KCWindlightInterface::applySkySettings: Checking if agent is in a defined zone newview/kcwlinterface.cpp(236) : 2016-10-09T01:23:07Z DEBUG: KCWindlightInterface::applySkySettings: Agent is not within a defined zone. Trying default now No further WL logging after this. I am seeing the correct region WL. Teleported to Location B - http://maps.secondlife.com/secondlife/Whippersnapper/23/13/22 (Nathan's place) Bug reproduced - I'm still seeing the red sky region WL from Gallifrey. I should be seeing the default day cycle sky. newview/llagent.cpp(995) : 2016-10-09T01:30:43Z INFO:#AgentLocation LLAgent::setRegion: Moving agent into region: Whippersnapper located at 216.82.50.48:13019 newview/llwlhandlers.cpp(53) : 2016-10-09T01:30:43Z INFO:#WindlightCaps LLEnvironmentRequest::initiate: Deferring windlight settings request until we've got region caps newview/kcwlinterface.cpp(211) : 2016-10-09T01:30:45Z DEBUG: KCWindlightInterface::applySkySettings: Checking if agent is in a defined zone newview/kcwlinterface.cpp(236) : 2016-10-09T01:30:45Z DEBUG: KCWindlightInterface::applySkySettings: Agent is not within a defined zone. Trying default now newview/kcwlinterface.cpp(111) : 2016-10-09T01:30:46Z DEBUG: KCWindlightInterface::parcelChange: Agent in new parcel: 554 newview/llagent.cpp(4598) : 2016-10-09T01:30:46Z INFO:#Teleport LLAgent::handleTeleportFinished: Agent handling teleport finished. No futher WL logging appeared. I'm still seeing the region WL from Gallifrey: http://prnt.sc/crjeil I Open Region/Estate floater and the WL correctly changes to the default day cycle: newview/llwlhandlers.cpp(121) : 2016-10-09T01:37:52Z INFO:#WindlightCaps LLEnvironmentRequest::environmentRequestCoro: Received region windlight settings newview/kcwlinterface.cpp(640) : 2016-10-09T01:37:52Z INFO: KCWindlightInterface::haveParcelOverride: Region environment settings received. Parcel WL settings will be overridden. Reason: No "RegionOverride" , region not using default WL and no zones defined or Parcel WL settings received - Region settings taking precedence newview/kcwlinterface.cpp(640) : 2016-10-09T01:37:52Z INFO: KCWindlightInterface::haveParcelOverride: Region environment settings received. Parcel WL settings will be overridden. Reason: No "RegionOverride" , region not using default WL and no zones defined or Parcel WL settings received - Region settings taking precedence Whirly_1.log attached from that session.
          Hide
          ansariel.hiller Ansariel Hiller added a comment -

          Can you give it another try with 50976 (http://hg.phoenixviewer.com/phoenix-firestorm-lgpl/rev/f7fb809308ad) which also added some more logging. And of course this will require testing FIRE-19972 again as well.

          Show
          ansariel.hiller Ansariel Hiller added a comment - Can you give it another try with 50976 ( http://hg.phoenixviewer.com/phoenix-firestorm-lgpl/rev/f7fb809308ad ) which also added some more logging. And of course this will require testing FIRE-19972 again as well.
          Hide
          whirly.fizzle Whirly Fizzle added a comment -

          Ansariel Hiller
          Testing on Firestorm 4.7.10 (50977) Oct 7 2016 08:01:18 (Firestorm-Fizzlefirex64) with OpenSimulator support
          Nathan's bug is fixed

          Now looking at Cheshyr's bug....

          Show
          whirly.fizzle Whirly Fizzle added a comment - Ansariel Hiller Testing on Firestorm 4.7.10 (50977) Oct 7 2016 08:01:18 (Firestorm-Fizzlefirex64) with OpenSimulator support Nathan's bug is fixed Now looking at Cheshyr's bug....
          Hide
          whirly.fizzle Whirly Fizzle added a comment - - edited

          Cheshyr's bug

          • Region WL
            • Sky - fixed sky - Coastal afternoon.
            • Water - Glassy.
          • Parcel WL
            /*Sky@20-104:"Coastal Afternoon" Sky@700-5000:"A-3AM" RegionOverride*/
            

          Ok I can reproduce Cheshyr's bug - but I don't think it's a bug - Ansariel said the same above too.

          I'm testing on Firestorm 4.7.10 (50977) Oct 7 2016 08:01:18 (Firestorm-Fizzlefirex64) with OpenSimulator support with the latest WL fixes.

          Repro

          • Set WL setting as shown in Cheshyr's image attached to this issue.
          • Go to any old location & set your local windlight settings to some easily recognized.
            I'm using Nacon's sweet dawn sky (bright orange) and Second Plague water (very red!).

          Observed

          • Sky correctly changes to Coastal afternoon parcel windlight.
            This is correct at the height (56m) because Parcel WL is
            /*Sky@20-104:"Coastal Afternoon" Sky@700-5000:"A-3AM" RegionOverride*/
            
          • Water remains set to Second Plague.
          • To me this seems correct.
            There is no parcel WL water defined for this parcel so you will see the windlight water set at the last location.
            The water here should not change to the region water setting because parcel PW is being used.

          Expected behaviour from Cheshyr

          My estate's water setting is ignored. Every time I login, or teleport back to Gallifrey, I see the default water instead of the settings I selected in estate tools.

          I believe this is the wrong assumption about expected behaviour.
          If you want that parcel to always show the glassy water (that you have set in the region WL), you would need to set Glassy water in the parcel windlight.

          Ansariel Hiller - if the above is correct then we can close this issue

          Show
          whirly.fizzle Whirly Fizzle added a comment - - edited Cheshyr's bug http://maps.secondlife.com/secondlife/Gallifrey/129/140/56 Region WL Sky - fixed sky - Coastal afternoon. Water - Glassy. Parcel WL /*Sky@20-104: "Coastal Afternoon" Sky@700-5000: "A-3AM" RegionOverride*/ Ok I can reproduce Cheshyr's bug - but I don't think it's a bug - Ansariel said the same above too. I'm testing on Firestorm 4.7.10 (50977) Oct 7 2016 08:01:18 (Firestorm-Fizzlefirex64) with OpenSimulator support with the latest WL fixes. Repro Set WL setting as shown in Cheshyr's image attached to this issue. Go to any old location & set your local windlight settings to some easily recognized. I'm using Nacon's sweet dawn sky (bright orange) and Second Plague water (very red!). TP to Gallifrey at http://maps.secondlife.com/secondlife/Gallifrey/129/140/56 Observed Sky correctly changes to Coastal afternoon parcel windlight. This is correct at the height (56m) because Parcel WL is /*Sky@20-104: "Coastal Afternoon" Sky@700-5000: "A-3AM" RegionOverride*/ Water remains set to Second Plague. To me this seems correct. There is no parcel WL water defined for this parcel so you will see the windlight water set at the last location. The water here should not change to the region water setting because parcel PW is being used. Expected behaviour from Cheshyr My estate's water setting is ignored. Every time I login, or teleport back to Gallifrey, I see the default water instead of the settings I selected in estate tools. I believe this is the wrong assumption about expected behaviour. If you want that parcel to always show the glassy water (that you have set in the region WL), you would need to set Glassy water in the parcel windlight. Ansariel Hiller - if the above is correct then we can close this issue
          Hide
          cheshyr Cheshyr Pontchartrain added a comment - - edited

          The reason I don't specify water in the parcel setting is because there isn't enough space. Parcel descriptions are far too short for any meaningful data, and the environment code for parcels is too long.

          I cannot imagine any scenario in which your expected behavior is logical. Under no circumstances should preferences from another sim be carried into new land. By your logic, any estate that doesn't set Windlight preferences is at the mercy of whatever sim you happened to visit most recently? This is a foolish assumption, and if it's a deliberate design choice, it must be corrected.

          Show
          cheshyr Cheshyr Pontchartrain added a comment - - edited The reason I don't specify water in the parcel setting is because there isn't enough space. Parcel descriptions are far too short for any meaningful data, and the environment code for parcels is too long. I cannot imagine any scenario in which your expected behavior is logical. Under no circumstances should preferences from another sim be carried into new land. By your logic, any estate that doesn't set Windlight preferences is at the mercy of whatever sim you happened to visit most recently? This is a foolish assumption, and if it's a deliberate design choice, it must be corrected.
          Hide
          ansariel.hiller Ansariel Hiller added a comment -

          Give it a try on 50978 (http://hg.phoenixviewer.com/phoenix-firestorm-lgpl/rev/aa887b00da28) - region water settings should be applied now (hopefully if the interpolation stuff doesn't mess it up again) if a sky WL other than region default has been applied but no water WL was specified.

          Show
          ansariel.hiller Ansariel Hiller added a comment - Give it a try on 50978 ( http://hg.phoenixviewer.com/phoenix-firestorm-lgpl/rev/aa887b00da28 ) - region water settings should be applied now (hopefully if the interpolation stuff doesn't mess it up again) if a sky WL other than region default has been applied but no water WL was specified.
          Hide
          ansariel.hiller Ansariel Hiller added a comment -

          Fixed or not fixed now?

          Show
          ansariel.hiller Ansariel Hiller added a comment - Fixed or not fixed now?

            People

            • Assignee:
              Unassigned
              Reporter:
              cheshyr Cheshyr Pontchartrain
            • Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated: