Uploaded image for project: 'Firestorm'
  1. Firestorm
  2. FIRE-6868

Having Growl enabled but not installed on the system causes 1 second freezes when friends login/logout and when receiving incomming IM's

    Details

    • Type: Bug
    • Status: Passed QA
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: Phoenix Firestorm 4.1.1
    • Fix Version/s: Phoenix Firestorm 4.4.5
    • Component/s: None
    • Environment:
    • SL Avatar Name:
      Alysson Sophie (alysson.velaystar)
    • Reported In:
      Firestorm 4.1.1.28570 QA

      Description

      When growl notifications are enabled, FS stalls (freezes) for about 1 sec every 10-15 secs, or when an IM is received, or when certain scripts are run (such as my spanker).

      Prefs > Dialog Alerts > enable both growl notifications boxes.

      Enable fast timers console, shift-ctrl-9, then wait for a stall with your mouse on the "pause" button. if you are fast enough to catch it, you will see a purple spike that takes up most of the lower pane and there will be a number in the 1000s on the same pane.

      Fast timers console indicates that when my screen stalls, "Process Messages" uses up 1004ms (26 calls), which adds up to the 1sec delay I am experiencing.

      I did a clean build twice, not saving settings or cache. When I disabled growl notifications, I was FPS-drop free for the 45 mins I ran it after.

      I do not have, to the best of my knowledge, any growl-enabled apps on my computer, so that could be why it is stalling, looking for a program that does not exist maybe?

        Issue Links

          Activity

          Hide
          whirly.fizzle Whirly Fizzle added a comment -

          Heya Alysson,

          Good catch!
          I couldnt repro this at first, until I uninstalled Growl from my system.

          With Growl uninstalled but enabled in the viewer, I see approx a 1 second freeze when a friend logs online or offline, and when I receive an incomming IM.

          Fast timers show the freeze is in Idle -> Network -> Idle network -> Process messages:

          With Growl installed, I actually get the same showing in fast timers, but the viewer does not freeze, strangely.

          Show
          whirly.fizzle Whirly Fizzle added a comment - Heya Alysson, Good catch! I couldnt repro this at first, until I uninstalled Growl from my system. With Growl uninstalled but enabled in the viewer, I see approx a 1 second freeze when a friend logs online or offline, and when I receive an incomming IM. Fast timers show the freeze is in Idle -> Network -> Idle network -> Process messages: With Growl installed, I actually get the same showing in fast timers, but the viewer does not freeze, strangely.
          Hide
          whirly.fizzle Whirly Fizzle added a comment - - edited

          Tested this on Phoenix Viewer 1691 while I had Growl uninstalled, and it has the same behaviour

          The Firestorm 4.0.1 release also behaves this way (There was no preference option in 4.0.1, use FSEnableGrowl and FSGrowlWhenActive in debug)

          Show
          whirly.fizzle Whirly Fizzle added a comment - - edited Tested this on Phoenix Viewer 1691 while I had Growl uninstalled, and it has the same behaviour The Firestorm 4.0.1 release also behaves this way (There was no preference option in 4.0.1, use FSEnableGrowl and FSGrowlWhenActive in debug)
          Hide
          katydid katydid62 resident added a comment -

          i've noticed that with Growl enabled there is a slight delay in messages coming up. they come up on Growl first then appear in the IM window. They trigger the little spinning wheel (for when your computer is busy) briefly as well.

          Show
          katydid katydid62 resident added a comment - i've noticed that with Growl enabled there is a slight delay in messages coming up. they come up on Growl first then appear in the IM window. They trigger the little spinning wheel (for when your computer is busy) briefly as well.
          Hide
          whirly.fizzle Whirly Fizzle added a comment - - edited

          Free has noted that she has seen a few cases already on 4.1.1 where users were reporting freezes and it was due to this issue.

          Suggestion from Zi: Find out of Growl is installed, and if not, disable useage, regardless of preference option set

          Show
          whirly.fizzle Whirly Fizzle added a comment - - edited Free has noted that she has seen a few cases already on 4.1.1 where users were reporting freezes and it was due to this issue. Suggestion from Zi: Find out of Growl is installed, and if not, disable useage, regardless of preference option set
          Hide
          ansariel.hiller Ansariel Hiller added a comment - - edited

          This needs (at least the Windows) Growl lib being changed. In it's current implementation, the Windows version always assumes connecting to the Growl service has been successful. It needs to store the information if the connection has been established successfully.

          Source for current implementation: https://github.com/psinnott/gntp-send/blob/master/source/growl%2B%2B.cpp

          Growl::Register needs to retain the return value from either growl_tcp_register or growl_udp_register and make the info available via Growl::isRegistered call, so Firestorm's GrowlNotifierWin::isUsable can return the correct state.

          Show
          ansariel.hiller Ansariel Hiller added a comment - - edited This needs (at least the Windows) Growl lib being changed. In it's current implementation, the Windows version always assumes connecting to the Growl service has been successful. It needs to store the information if the connection has been established successfully. Source for current implementation: https://github.com/psinnott/gntp-send/blob/master/source/growl%2B%2B.cpp Growl::Register needs to retain the return value from either growl_tcp_register or growl_udp_register and make the info available via Growl::isRegistered call, so Firestorm's GrowlNotifierWin::isUsable can return the correct state.
          Hide
          ansariel.hiller Ansariel Hiller added a comment -

          Basically fixed in 33885 (http://hg.phoenixviewer.com/phoenix-firestorm-lgpl/rev/bc80bf8b0c4a) together with the updated growl lib. Preferences option should be adjusted now, for instance only enable the checkbox if Growl is available.

          Show
          ansariel.hiller Ansariel Hiller added a comment - Basically fixed in 33885 ( http://hg.phoenixviewer.com/phoenix-firestorm-lgpl/rev/bc80bf8b0c4a ) together with the updated growl lib. Preferences option should be adjusted now, for instance only enable the checkbox if Growl is available.
          Hide
          ansariel.hiller Ansariel Hiller added a comment -
          Show
          ansariel.hiller Ansariel Hiller added a comment - Preferences changed in 33915 ( http://hg.phoenixviewer.com/phoenix-firestorm-lgpl/rev/fc7450377078 ).
          Hide
          aprille.shepherd Aprille Shepherd added a comment -

          I will test and get back to you on what i find when in 33915. I had to go back to 4.3.1 dues to several issues (including black screen) which i will help to test as well.

          Show
          aprille.shepherd Aprille Shepherd added a comment - I will test and get back to you on what i find when in 33915. I had to go back to 4.3.1 dues to several issues (including black screen) which i will help to test as well.
          Hide
          whirly.fizzle Whirly Fizzle added a comment -

          Heya Aprille,

          I just sent you a private message from JIRA with a download link.

          This build has the fix in for FIRE-9928 (Group Notice Windows Lose Focus) and also the black screen issue, as well as this issue.

          Thanks for testing and please let is know if you see any problems

          Show
          whirly.fizzle Whirly Fizzle added a comment - Heya Aprille, I just sent you a private message from JIRA with a download link. This build has the fix in for FIRE-9928 (Group Notice Windows Lose Focus) and also the black screen issue, as well as this issue. Thanks for testing and please let is know if you see any problems

            People

            • Assignee:
              ansariel.hiller Ansariel Hiller
              Reporter:
              alysson.velaystar Alysson Sophie
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: